fix compatibility issue with NumPy>=2.4.0 - #3
Open
fishilico wants to merge 1 commit into
Open
Conversation
When using recent NumPy, `nsec3hash.py` fails with:
sol = int(self.solutions[i])
~~~^^^^^^^^^^^^^^^^^^^
TypeError: only 0-dimensional arrays can be converted to Python scalars
This comes from a change from NumPy 2.4.0, documented in
https://numpy.org/devdocs/release/2.4.0-notes.html#raise-typeerror-on-attempt-to-convert-array-with-ndim-0-to-scalar
> Raise `TypeError` on attempt to convert array with `ndim > 0` to scalar
>
> Conversion of an array with `ndim > 0` to a scalar was deprecated in
> NumPy 1.25. Now, attempting to do so raises `TypeError`. Ensure you
> extract a single element from your array before performing this
> operation.
As `self.solutions` is a NumPy array with shape `(self.max_nholes, 1)`,
adding `[0]` fixes this issue. Add `[0]` in other places as well, to
make the code more robust to future NumPy changes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
When using recent NumPy,
nsec3hash.pyfails with:This comes from a change from NumPy 2.4.0, documented in https://numpy.org/devdocs/release/2.4.0-notes.html#raise-typeerror-on-attempt-to-convert-array-with-ndim-0-to-scalar
As
self.solutionsis a NumPy array with shape(self.max_nholes, 1), adding[0]fixes this issue. Add[0]in other places as well, to make the code more robust to future NumPy changes.